search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
26 stars 25 forks source link

[DISCUSSION]: Change GitHub default branch to Development #430

Closed xscottxbrownx closed 9 months ago

xscottxbrownx commented 10 months ago

Bug Title:

GH Issues must be closed manually

Bug Description:

Our current default branch in GH is set to Master, this means issues do not close until code has been merged into the Master branch - therefore all issues are currently closed manually when merging PRs into Development.

Expected Behavior:

If default branch is set to Development and either use keywords of "close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved" OR manually linking an issue (from the side menu/info), then when a PR is merged it will automatically close that issue as well. See here and here

Additional Context:

It could be fair to say the issue is not really resolved, until it is resolved in the Master branch. This is why I am opening this for discussion. But, we are closing issues once they are resolved in the Development branch - so if we continue that way I propose we change the default branch to Development. GH instructions here

Jared-Krajewski commented 10 months ago

We essentially only used development because we wanted master to host the latest "live" version for GH pages. I think the new deployment also pulls from master so it is probably still a good idea to switch it to Development for the incremental small pushes with weekly or bi-weekly push to master. I think when this was briefly brought up in a meeting a few weeks ago the general agreement was to switch to development.

timbot1789 commented 10 months ago

I'm fine with this. I don't think there are any integrations that would break from this change.

xscottxbrownx commented 9 months ago

It seems people are in agreement from comments here and discussions in person, but I don't have admin access to this repo to be able to change this setting.

Maybe @Jared-Krajewski or @leekahung? Do either of you have ability to click settings in top bar and switch default branch to Development?

leekahung commented 9 months ago

I'll have the default branch switched up to Development

leekahung commented 9 months ago

Have the default branch switched up to Development from Master. Closing issue #430.