search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
26 stars 25 forks source link

I've removed the inaccurate lines for renderWebId and AddContactModal… #434

Closed malcyb123 closed 9 months ago

malcyb123 commented 10 months ago

Editing jsDoc's for AddContactModal

This PR:

Resolves #422

1.
2. If needed, delete if not
3. If needed, delete if not

xscottxbrownx commented 10 months ago

I'm honestly fairly new with jsdoc, but why removing the @name's?

leekahung commented 10 months ago

I believe you originally meant fixing the @param tags @xscottxbrownx in #422?

xscottxbrownx commented 10 months ago

I believe you originally meant fixing the @param tags @xscottxbrownx in #422?

Honestly, I'm not sure... I should've screenshot what was there at the time of writing up the issue.

Looking at them now, I'm not sure the params are incorrect. But, I've never seen us write them this way (that they are the React props object.) Not sure it's wrong though.

bingeboy commented 10 months ago

LGTM but looks like the description of the PR needs a little updating.

andycwilliams commented 9 months ago

It looks like this is both from a forked repo and is merging into the master branch. We merge into the development branch before initiating larger merges into master.

xscottxbrownx commented 9 months ago

It looks like this is both from a forked repo and is merging into the master branch. We merge into the development branch before initiating larger merges into master.

Agreed, this needs to go into development.

timbot1789 commented 9 months ago

@mal092 this has been inactive for 3 weeks. Will you be able to return to this soon?

timbot1789 commented 9 months ago

@mal092 This PR has been inactive for 1 month, with no activity. We will be closing it. If you would like to reopen it, you can reach out in the dev channel on our discord.