search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
26 stars 25 forks source link

Issue-444 / fix alt typo for images #445

Closed xscottxbrownx closed 9 months ago

xscottxbrownx commented 9 months ago

This PR:

Resolves #444

1. Replaces lt typo with alt

bingeboy commented 9 months ago

Once test/pages/__snapshots__/Home.test.jsx.snap is updated for the test to pass this LGTM 👍

xscottxbrownx commented 9 months ago

Thanks all, I'll need to dig into this - I was under the impression it wasn't good practice to use snapshots when unit testing front-end react code. I missed this entirely.

timbot1789 commented 9 months ago

Thanks all, I'll need to dig into this - I was under the impression it wasn't good practice to use snapshots when unit testing front-end react code. I missed this entirely.

I added some snapshots in older tests when we were first writing the tests, since we used them at my last job a lot. I've come to agree though that snapshots aren't particularly useful. You can remove it if you want, but I'd ask you add some other tests in that show the intended behavior of the component (RTL stuff)

xscottxbrownx commented 9 months ago

Looks like this is causing a test failure. You'll need to fix that before we can merge this.

Got snapshot updated and passing.