codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
24 stars 24 forks source link

Bug: (Contacts) "No contacts found" using `h2` for content instead of organization #518

Closed milofultz closed 7 months ago

milofultz commented 7 months ago

Bug Description:

When no contacts are found, the main content ("No contacts found") uses an h2 instead of something more semantically appropriate. Headings should be used for navigation, not for content.

Reproduction Steps:

1. Log in to an account that has no contacts. 2. Go to the Contacts tab. 3. Observe the DOM of the content ("No contacts found").

Expected Behavior:

The content should be something like a p tag or similar.

Screenshots (If applicable):

The Contacts tab of a logged in user, showing 'No contacts found' prominently in the center.

Additional Context (optional):

Possible Solution (optional):

milofultz commented 7 months ago

This is found in the EmptyListNotifications component

JonnyMc94 commented 7 months ago

Hi @milofultz, I would like to work on this if you could assign it to me please?