codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
28 stars 25 forks source link

Make footer headings the appropriate heading level #520

Closed milofultz closed 10 months ago

milofultz commented 10 months ago

Was mentioned in #456, but was small enough I thought could make it a small PR.

Since the footer is separate from the main content, and a page should only have one h1, this means that a footer should have their headings start at h2.

milofultz commented 10 months ago

This is what I would've done to it too, but see my discord DM comments - as I'm not sure it's quite right for pages besides the logged out home page.

Because the footer stays the same throughout all the pages (afaict) and there will only ever be a single h1, that means that an h2 will always be semantically appropriate.

Sounds like it doesn't matter for SEO and each heading has relevant content beneath it, so seems legit to me.