search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
28 stars 25 forks source link

[Enhancement] - Vertical scrolling for sign in autocomplete #539

Open leekahung opened 10 months ago

leekahung commented 10 months ago

Describe the Current Behavior/Feature:

Was originally described in https://github.com/codeforpdx/PASS/pull/537#pullrequestreview-1743775571 this is mainly for the mobile view. But it looks like the issue is somewhat resolved by allowing the modal to stretch instead (see clip).

https://github.com/codeforpdx/PASS/assets/14917816/9f655e48-715b-4d3f-8277-260102d224d9

Still think it'll be better if we could keep the modal from changing and allow the autocomplete vertical scroll, but that's just a nit. If there's consensus with this, think we could get this implemented.

Rationale:

Quality of life for mobile version of PASS.

Proposed Implementation (if applicable):

Enable vertical scrolling for the element in question. Could keep the viewable height of the autocomplete list to a fixed height.

leekahung commented 10 months ago

Keeping this open fo now.

andycwilliams commented 4 months ago

What's the status of this issue now?