codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
24 stars 24 forks source link

501/navbar hamburger menu and notification bell improvements #548

Closed richestrinh closed 7 months ago

richestrinh commented 7 months ago

This PR:

Resolves #501

1. Updated positioning for hamburger menu and bell drop-down to appear below nav bar. 2. Updated backdrop for hamburger menu and bell.
3. Fixed hamburger menu icons to have consistent sizing. 4. Updated spacing around divider seperating routes and settings.

Screenshots (if applicable):

PASS_Issue#501

leekahung commented 7 months ago

I think removing the one layer of padding should be sufficient. Removing both layers of padding makes the menu seem too crowded/squished? The spacing between sections (like that of Profile and Settings) looks just right.

Screen Shot 2023-11-30 at 17 35 56

Of course, there's a divider, but think that distance from the bottom of profile to the divider or from the top of settings to the divider looks pretty good. The problem before was that the padding was doubled up when only one layer of padding is needed.

richestrinh commented 7 months ago

I approved, and then realized there is a difference on full mobile menu (when contacts and civic profile are also in the menu.)

The padding isn't consistent on that one compared to the others that were changed.

I think it's still the double padding version.

I think it had to do with the min-height for the mobile view. Here's what it looks like after my fix!

PASS#501_MinHeight