#549 No whitespace on form submission

codeforpdx / PASS

PASS project - with HMIS module integration

MIT License

24 stars 24 forks source link

#549 No whitespace on form submission #553

Closed milofultz closed 7 months ago

milofultz commented 7 months ago

Resolves #549

1. Strips leading/trailing whitespace before submission 2. Cleans up some other cruft I found along the way

milofultz commented 7 months ago

I added a FormSection to the NewMessage modal because I realized that should probably be done the same way as the other one, and now they both have labels.

milofultz commented 7 months ago

See my previous comments, but the big one for me is to make that one conditionally rendered so it's not adding needlessly to the DOM.

Got all these fixes in! If you're happy, feel free to merge it in.

leekahung commented 7 months ago

Looks like there was a pretty significant divergence that happened, but I got everything patched up. 👍

It should be good to go from my end @milofultz. Think you've address the points I've mentioned. Awaiting other reviewers.