search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
28 stars 25 forks source link

footer enhancment #562

Closed Heun11 closed 9 months ago

Heun11 commented 9 months ago

This PR:

Resolves #559

1. Changed "Follow Us" to "Connect" 2. Added LinkedIn icon and link to https://www.linkedin.com/company/code-pdx/

Screenshots:

image

xscottxbrownx commented 9 months ago

@timbot1789 are we now taking code updates from people who have not gone through any code pdx info?

Heun11 commented 9 months ago

@xscottxbrownx there you go, I've done the changes. I'm sorry but I don't have much experience with github pull request and issues.

timbot1789 commented 9 months ago

@timbot1789 are we now taking code updates from people who have not gone through any code pdx info?

I've never had a strong opinion about what qualifies as a proper source for a PR. That's something to discuss with Flo and @htharker42.

A lot of other open source projects allow people to submit PRs in the way @Heun11 has done here (some require it), so I haven't felt the need to enforce something. Git also doesn't make a distinction between a PR from a repo "fork" and a PR from any other branch. That's a distinction we've created for ourselves/ is provided by Github.

xscottxbrownx commented 9 months ago

@timbot1789 are we now taking code updates from people who have not gone through any code pdx info?

I've never had a strong opinion about what qualifies as a proper source for a PR. That's something to discuss with Flo and @htharker42.

A lot of other open source projects allow people to submit PRs in the way @Heun11 has done here (some require it), so I haven't felt the need to enforce something. Git also doesn't make a distinction between a PR from a repo "fork" and a PR from any other branch. That's a distinction we've created for ourselves/ is provided by Github.

It was my understanding this was already a direction coming straight from Flo, and I was wondering if I had missed an update about it.

I personally believe we should allow anybody to work on the codebase and merge if it's a good change and approve, but that wasn't what Flo wanted as far as I know. Last I heard, they wanted individuals to go through the steps outlined for contributing to Code PDX.

xscottxbrownx commented 9 months ago

@xscottxbrownx there you go, I've done the changes. I'm sorry but I don't have much experience with github pull request and issues.

No need to apologize! The only way to gain experience is to do it.

I've got one more change I'd like to see on this PR which doesn't technically have to do with your changes, but just noticed something that isn't necessary in this file.

Lines 75-86: