codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
28 stars 25 forks source link

Enhancement 534: Updated node to v18 and npm modules #569

Closed bingeboy closed 8 months ago

bingeboy commented 8 months ago

This PR:

Resolves #534

1. Make sure you run nvm use before testing this PR.

Screenshots (if applicable):

NA

Additional Context (optional):

Future Steps/PRs Needed to Finish This Work (optional):

Believe everything is functional for review.

Issues needing discussion/feedback (optional):

1. Verify the CCS config is working as expected.

bingeboy commented 8 months ago

@leekahung Hey, I have updated the CSS config as described in the CSS release notes. The PASS client seems to be working fully and the podserver isn't throwing any errors. There are newer Solid client modules v2.x but that isn't required for Node v18. IMO doing that in a separate PR would limit risk. I'm not super familiar with CSS so any feedback would be helpful.

leekahung commented 8 months ago

Hey JP, thanks for the heads up! With regards to registering a new pod, how would we do that now with the new version? I've tried following the instructions from their documentation (see screenshot and clip):

Screenshot 2024-01-29 at 1 03 14 PM

https://github.com/codeforpdx/PASS/assets/14917816/454c6495-1298-486f-885d-817490f1b25f

However, I could not register for a new pod using this approach.

bingeboy commented 8 months ago

Ok, I'll have to look into that. I just made mine signing in through PASS.

leekahung commented 8 months ago

Ok, I'll have to look into that. I just made mine signing in through PASS.

Ah, okay. I'll try just doing it that way.

bingeboy commented 8 months ago

Sounds good. Thanks!