search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
24 stars 24 forks source link

Enhancement: Update document sharing modal to pull from contacts list #573

Closed timbot1789 closed 2 months ago

timbot1789 commented 5 months ago

Describe the Current Behavior/Feature:

Currently, to share a document with someone, you must enter their pod URL. This is hard for users because it requires them to remember the Pod URL of everyone they want to share with. Conceptually it is incorrect as well, because you do not share with a pod, you share with a Web ID image

Proposed Behavior/Feature:

Rework the sharing modal to share with people off their contact list. This can use the same functionality as currently exists in the messaging system (a dropdown that searches the contact's first and last name). image

Additional context:

This may require removing logic around adapting the "pod url." This logic is unnecessary. If we have a person's web Id, we can use it directly.

bingeboy commented 3 months ago

@leekahung I've been tied up with other obligations so I've unassigned this ticket. Hopefully, I'll have time to code again soon.

timbot1789 commented 3 months ago

No worries. Thanks for letting us know @bingeboy

leekahung commented 3 months ago

@leekahung I've been tied up with other obligations so I've unassigned this ticket. Hopefully, I'll have time to code again soon.

All good, thanks for your contributions up to now!

joshua-cornett commented 3 months ago

I believe I've finished implementing webID sharing in place of podURLs as well as a contacts/webIDs dropdown. I'm not seeing how document sharing is tested, though, to include when I stash my changes to cross-reference the original state. Obviously I want to confirm this works before I try to merge and close 😅. How should I be testing it?