fixed linting errors, resolved issue

codeforpdx / PASS

PASS project - with HMIS module integration

MIT License

24 stars 24 forks source link

fixed linting errors, resolved issue #575

Closed fighawkins closed 4 months ago

fighawkins commented 4 months ago

This PR:

Resolves #572

1. Removed username field and its associated traces from contact list related files. 2. Changed first name and last name fields from required to optional. 3. commented out renderWebId function, as it used username in creating a url. i did not delete in case we want to repurpose.

Screenshots (if applicable):

here is a screenshot of the data table as is currently displayed. I am curious if we need/want the webId included in the rows, as right now it is not included in the displayed data, though is being stored and can be seen upon visiting the profile for that contact.

timbot1789 commented 4 months ago

Looks Good! Feel free to merge it whenever you want.

leekahung commented 4 months ago

Hey @fighawkins! Just to let you know that this PR looks good for merging. Was wondering if there's still anything you'd think still needs to be gone over.

fighawkins commented 4 months ago

okay, I apologize for this, but there was a conflict that needed resolved before it would let me merge, so I attempted to take care of it but now it is showing a check not passing, having to do with prettier. I'm a little unsure of how to take care of it, so just checking in

leekahung commented 4 months ago

Looks like Prettier picked up a formatting issue post-conflict resolution. The extra empty line in AddContactModal.tsx should be pretty easy to take care of. You can either do it manually or with npm run prettier:run. After that, just push the changes.