search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
24 stars 23 forks source link

586 feature request add sign up with existing pod option to the sign up page #609

Closed russfraze closed 2 months ago

russfraze commented 3 months ago

This PR:

Created the register with existing pod form on the signup page which accepts the URL to a pod provider.

Test steps

  1. Create a new pod with https://opencommons.net/
  2. On the Pass signup page, enter https://opencommons.net/ in the pod provider field in the register with existing pod form.
  3. Click the login to pod provider button.
  4. You should be redirected to https://opencommons.net/
  5. Login and you should be redirected back to pass. Confirm that you are signed in.
timbot1789 commented 2 months ago

This looks good overall. I was able to sign up with an existing pod, and the data was initialized.

2 requests:

  1. Can the page switch over to the ShowNewPod component, or a slightly updated ShowSetup component?
  2. Can you add a unit test that shows the RegisterWithExistingPod calls the expected functions?
russfraze commented 2 months ago

@timbot1789 ready for review.

russfraze commented 2 months ago

@leekahung thanks for that feedback. I changed it so the styles are in the sx prop for the MUI components. Just a heads up, I think the reason I did that in the first place is because I copied the styles from the PodRegistration component which still uses the style prop for its MUI components. For consistency, we could change that component too.

I think this PR should be good to go now.