Enhancement update document sharing modal to pull from contacts list (#573)

codeforpdx / PASS

PASS project - with HMIS module integration

MIT License

24 stars 23 forks source link

Enhancement update document sharing modal to pull from contacts list (#573) #611

Closed joshua-cornett closed 2 months ago

joshua-cornett commented 2 months ago

This PR:

Resolves #573

1. Document sharing (SetAclPermissionsModal) uses Web ID instead of Pod URL
2. Populates a dropdown of contacts and associated Web IDs 3. Side improvement: Header of FormSection no longer overflows

Screenshots:

joshua-cornett commented 2 months ago

Very minor issues, think it should be good to go after they're addressed

Understood, taking care of it now - thanks for reviewing!

leekahung commented 2 months ago

Very minor issues, think it should be good to go after they're addressed

Understood, taking care of it now - thanks for reviewing!

Hey Josh, thanks for bearing with me! Just a few more things, but I've made sure this time that it really should be good to go.

joshua-cornett commented 2 months ago

Ah I see, not sure how I missed those. I'll take a look and get them sorted.

leekahung commented 2 months ago

I'll have this PR merged into the development branch. 👍