search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
24 stars 23 forks source link

622 standardize all input fields #628

Closed DionSat closed 1 month ago

DionSat commented 1 month ago

This PR:

Resolves #622

1. Standardize New Message Modal 2. Standardize Add Contact Modal 3. Standardize Upload Document Modal

Screenshots (if applicable):

image

image

image

andycwilliams commented 1 month ago

Only just noticing this. When using different browsers I got different margins for the same modal.

Chromium:

2024-05-08 (15)

Firefox:

2024-05-08 (14)

Haven't looked too much into this, but it may have to do with that modal using <br> rather than setting the margins as "normal" the way other ones do. Add Contact uses margin="normal" rather than <br> and looks the same on both browsers.

DionSat commented 1 month ago

Thanks for finding that. This is why I didn't want to finalize the PR yet. Because there are different modals I haven't checkout yet. I'll be sure to check that out and see if I can find any other issues once I'm back from work.

andycwilliams commented 1 month ago

Thanks for finding that. This is why I didn't want to finalize the PR yet. Because there are different modals I haven't checkout yet. I'll be sure to check that out and see if I can find any other issues once I'm back from work.

A long while back we were talking about not using <br />s and just use MUI's styling. But we never really settled on a plan so it's become a hodgepodge. This would be a good opportunity to standardize them.

DionSat commented 1 month ago

I just decided to remove all the <br /> tags from the modals. It seems to be running fine on my firefox and chrome. Hopefully thats everything I'll be moving this over to review.

leekahung commented 1 month ago

I'm in favor of using styling/CSS to adjust for spacing over <br /> since we'll have more control over margin and padding sizes.