faddah
commented
3 weeks ago @leekahung @andycwilliams @Jared-Krajewski — i have added, with the kind assistance of @leekahung, the correct code in HousingInof.jsx & HousingInfo.test.jsx the correct code to get all tests to pass, including a new unit test to make sure the clear button is working. All tests are now passing and the feature requested in Issue #513 are now working in this 513-Enhancement-Civic-Profile-Housing-Information-Form branch. @leekahung & @andycwilliams — if you could please change your Changes requested above to resolved, then either you folks or i could merge this to Development and put it to bed. please let me know if you'll be doing or if you want me to do it. thanx again for all the kind help!
leekahung
andycwilliams
This PR:
Resolves #513 - Enhancement: Civic Profile - Housing Information Form
1. I have added all the appropriate @mu and made sure they they fit in a web browser screen. The main files changes were
src/components/HousingInfo.jsx,src/pages/CivicProfile.jsx(to increass the CSS styling width of the container), and the unit tests —test/components/HousingInfo.test.jsx. I've checked that they are working properly. 2. I have run the linter, prettier and the unit tests that I added plus the unit test fortest/pages/CivicProfile.test.jsxto make sure they run and pass and they do.Screenshots (if applicable):
Add any screenshots/videos here.
Additional Context (optional):
N/A.
Future Steps/PRs Needed to Finish This Work (optional):
Need to look at Mobile @Media screen sizes — right now,if you try and decrease the screen size to the size of a phone screen, you lose and cannot really get to all the fields I added to the right.
Issues needing discussion/feedback (optional):
1. The next screen, Financial Info, still has no fields and needs to be fleshed out.