search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
24 stars 23 forks source link

Fix links in pod registration card #647

Closed AJSterner closed 3 weeks ago

AJSterner commented 1 month ago

This PR:

Resolves #645

The pod registration page wasn't registering the pod links correctly! Now it does.

Screenshots (if applicable):

Before Screenshot_20240521_184038 After Screenshot_20240528_182502

andycwilliams commented 3 weeks ago

Don't want to be too picky on this since it looks like it's working, but was wondering if we should start replacing the existing <br /> with <span>/<p> elements or include styling to the MUI <Typography /> components so that we have more control over spacing/padding/margins in the future in case we want to update them.

Other than that, can approve this change.

That definitely should be done but I'm fine with leaving it for another PR as this one is pretty focused. And these might already be covered by #587. Otherwise we can create a new issue.

leekahung commented 3 weeks ago

Think we can merge this for now then. 👍

AJSterner commented 3 weeks ago

image Updated to use MUI!