search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
24 stars 23 forks source link

[WIP] 587: Restyle Sign In #653

Open AJSterner opened 3 weeks ago

AJSterner commented 3 weeks ago

This PR:

Resolves #587

1.
2. If needed, delete if not
3. If needed, delete if not

Screenshots (if applicable):

Add any screenshots/videos here.

Additional Context (optional):

Add any other context about the PR here.

Future Steps/PRs Needed to Finish This Work (optional):

Add any other steps/PRs that may be needed to continue this work if this PR is just a step in the right direction.

Issues needing discussion/feedback (optional):

1.
2. If needed, delete if not
3. If needed, delete if not

andycwilliams commented 3 weeks ago

Is this open for reviewing or is it still a WIP? It seems to be based off of an outdated version of the main branch. It still has the green theme. Nevermind, I was looking at the other, outdated branch instead of this one.

Edit: Just saw your comments on the issue. Would it help to change this to a draft PR for the time being?

AJSterner commented 3 weeks ago

Is this open for reviewing or is it still a WIP? It seems to be based off of an outdated version of the main branch. It still has the green theme.

Edit: Just saw your comments on the issue. Would it help to change this to a draft PR for the time being?

Changed to draft!

andycwilliams commented 1 week ago

Hey. No rush. Just wondering what the current status is.

AJSterner commented 4 days ago

Hey. No rush. Just wondering what the current status is.

I just got back from a trip and am picking this up again today. Hoping to get it finalized this week.

AJSterner commented 4 days ago

Love the changes. Several things to comment, was wondering if we could horizontally center the tabs and buttons, the rest are fine.

Will do!

As for the email field was wondering if we could make it the same widths as the password and confirm password and use a similar design style. Been starting to see contrasting input field types. Would be best if we stick with one of the two styles.

Yup, I have a local commit fixing this issue.

Also for the component (see clip), changing tabs causes the component/page to jump. Was thinking we could the content for Existing Pod be the same height as New Pod, or mess with the spacing/margin/padding around the card so that only the height is changing. Screen.Recording.2024-06-26.at.1.03.45.AM.mov

That would help chop down on the clunkiness. Thanks!

So this "jumping" seems to be caused by the NavBar overflowing. If we remove display: 'grid' in the Box containing the navbar, the issue goes away (see the screencast), but I'm not sure what the fallout would be otherwise. I can play around with it to see if it breaks other pages. The grid display was added by you (@leekahung) here

Screencast_20240627_204301.webm