search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
24 stars 23 forks source link

add loading animation to upload doc modal #654

Open russfraze opened 2 weeks ago

russfraze commented 2 weeks ago

This PR:

Resolves #(654)

Screenshots (if applicable):

Add any screenshots/videos here.

Additional Context (optional):

I've implemented this and you can see the loading animation for a split second when uploading a document. I uploaded a 12MB image and it still only takes a split second. I'm wondering if that is because I am using the local pod server?

I think this loading animation makes for a better user experience if the file is large enough to take a couple of seconds, for sure.

Future Steps/PRs Needed to Finish This Work (optional):

This needs further styling to match the Figma file.

Issues needing discussion/feedback (optional):

Currently, the loadingAnimation component delivers an indeterminant progress bar which is fine, but the Figma file shows a determinate progress bar with a percentage of the upload progress. Let me know if we intend to have a determinate progress bar here and I can look into how to make that work.

andycwilliams commented 2 weeks ago

Just to make sure, is this still a draft or are you looking for a review already?

russfraze commented 2 weeks ago

@andycwilliams this is still a draft, for sure. I should have just pinged you instead of requesting a review.