search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
24 stars 23 forks source link

[Bug fix] - Issue-650/bug fix mismatch pass pod creation #657

Open leekahung opened 5 days ago

leekahung commented 5 days ago

This PR:

Resolves #650 by introducing validation and a disabled button until the error is corrected.

Screenshots (if applicable):

https://github.com/codeforpdx/PASS/assets/14917816/92d4d565-4136-4512-90b9-164a7867c7f3

andycwilliams commented 5 days ago

Looks good, only suggestion is to mark Password and Confirm Password as required, and to disable the button until everything is properly filled. Either that, or have text appear while the passwords don't match, like helperText="Passwords must match"

leekahung commented 4 days ago

Looks good, only suggestion is to mark Password and Confirm Password as required, and to disable the button until everything is properly filled. Either that, or have text appear while the passwords don't match, like helperText="Passwords must match"

I'll add it

leekahung commented 4 days ago

Since it's a FilledInput, there are no attributes for helperText. Instead, I've used FormHelperText to help add the helper texts for the password mismatch

https://github.com/codeforpdx/PASS/assets/14917816/552cd60f-2cd2-400d-8b24-14ba312ebce8

The alignment issues and styling will be resolved once PR #653 is reviewed and merged, so that's been left alone here. For this PR, it's mainly focused on fixing the bug.

andycwilliams commented 4 days ago

The helper does, well, help.

Come to think of it, I'm not sure why it uses FilledInput here. This is the only place we have it, otherwise we just use TextField.

And I'd still like to see the password fields marked as required and the "Set up your Pod" button disabled until all requirements are met. Same for "Login to Pod Provider".

leekahung commented 4 days ago

The helper does, well, help.

Come to think of it, I'm not sure why it uses FilledInput here. This is the only place we have it, otherwise we just use TextField.

And I'd still like to see the password fields marked as required and the "Set up your Pod" button disabled until all requirements are met. Same for "Login to Pod Provider".

We could open for a separate PR for those. This is mainly for the bug fix.