codeforpdx / codepdx_website

https://www.codepdx.org
1 stars 3 forks source link

Enhancement: Increase font size of Menu Items & Bold #116

Closed nujabes77 closed 4 months ago

nujabes77 commented 7 months ago

Describe the Current Behavior/Feature:

Increase font size of Menu Items & Bold

Screenshot 2024-02-10 at 1 06 51 PM
Jared-Krajewski commented 7 months ago

their current size of 16px or 1 rem is standard nav bar text size (sometimes 14 is even use), what size would you like them to be?

nujabes77 commented 7 months ago

Bigger!

Check out the website layout it’s tiny

On Mon, Feb 12, 2024 at 11:41 Jared Krajewski @.***> wrote:

their current size of 16px or 1 rem is standard nav bar text size (sometimes 14 is even use), what size would you like them to be?

— Reply to this email directly, view it on GitHub https://github.com/codeforpdx/codepdx_website/issues/116#issuecomment-1939429682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5R3GAHIJ6QQ6DJJ3KJ3PLYTJV7TAVCNFSM6AAAAABDC7KR6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGQZDSNRYGI . You are receiving this because you authored the thread.Message ID: @.***>

Jared-Krajewski commented 7 months ago
Screenshot 2024-02-12 at 12 42 56 PM

heres our nav items along side another very popular civic tech groups nav items.

Screenshot 2024-02-12 at 12 43 47 PM

heres our nav items next to discords website nav items.

If they are small for you it may be something your local text scaling?

we can increase the font weight to 600 still as home appears in the last 2 screenshots.

Screenshot 2024-02-12 at 12 45 28 PM

If contrast is the issue, we had been talking about possibly having to switch to the darker green that is used in some versions of our logo to help with contrast around the site.

Screenshot 2024-02-12 at 12 54 34 PM
nujabes77 commented 7 months ago

Change it to 600!

On Mon, Feb 12, 2024 at 12:47 PM Jared Krajewski @.***> wrote:

Screenshot.2024-02-12.at.12.42.56.PM.png (view on web) https://github.com/codeforpdx/codepdx_website/assets/114430929/4b0a524b-aeaf-4e0a-975a-c5f48bbd8b98

heres our nav items along side another very popular civic tech groups nav items. Screenshot.2024-02-12.at.12.43.47.PM.png (view on web) https://github.com/codeforpdx/codepdx_website/assets/114430929/1a0eb464-08d1-47f1-b4af-e2e1d1deffbb

heres our nav items next to discords website nav items.

If they are small for you it may be something your local text scaling?

we can increase the font weight to 600 still as home appears in the last screenshot. Screenshot.2024-02-12.at.12.45.28.PM.png (view on web) https://github.com/codeforpdx/codepdx_website/assets/114430929/e68bb994-9607-415f-a637-7fe7f9f62ccf

— Reply to this email directly, view it on GitHub https://github.com/codeforpdx/codepdx_website/issues/116#issuecomment-1939544776, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5R3GHFWLITEENT6H3UJ6TYTJ5UXAVCNFSM6AAAAABDC7KR6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGU2DINZXGY . You are receiving this because you authored the thread.Message ID: @.***>

andycwilliams commented 7 months ago

This is what it looks like with font weight at 600. Right now it's applying to the CODE PDX title as well. I can exclude that but wanted to show what that looks like.

Capture
andycwilliams commented 7 months ago

So are we decided on 600?

Jared-Krajewski commented 7 months ago

So are we decided on 600?

yes, could try font 17 but 16 is larger standard size already. changes apply to nav links only.

andycwilliams commented 7 months ago

Two possibilities:

With variant="h6" and component="p":

h6

With fontSize={17} & fontWeight={600}:

fontSizeAndWeight
andycwilliams commented 5 months ago

What's the current status for this issue?

Jared-Krajewski commented 5 months ago

font weight to 600 and leave size at 1 rem (16px) for only the 3 nav links to match what the rest of the world does.