vercel[bot]
commented
8 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
Closed andycwilliams closed 8 months ago
vercel[bot]
commented
8 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
nujabes77
commented
8 months ago New wording. 43 words shorter
Volunteering is all about making a difference and having fun while doing it. You don't need to worry about being the perfect fit - just bring your willingness to help out, and you're good to go!
We welcome people from all walks of life, whether you're a seasoned pro or just starting out. Maybe you're already seasoned, or perhaps you're looking to learn something new - either way, there's a place for you here.
So go ahead, dive into volunteering with enthusiasm, and let's make a positive impact together!
Contribute what you can, when you can, and know that your efforts are appreciated.
Jared-Krajewski
commented
8 months ago New wording. 43 words shorter
Volunteering is all about making a difference and having fun while doing it. You don't need to worry about being the perfect fit - just bring your willingness to help out, and you're good to go!
We welcome people from all walks of life, whether you're a seasoned pro or just starting out. Maybe you're already seasoned, or perhaps you're looking to learn something new - either way, there's a place for you here.
So go ahead, dive into volunteering with enthusiasm, and let's make a positive impact together!
Contribute what you can, when you can, and know that your efforts are appreciated.
suggesting
We welcome people from all walks of life, whether you're a seasoned pro or just starting out. Maybe you're already seasoned, or perhaps you're looking to learn something new - either way, there's a place for you here.
to
We welcome people from all walks of life. Whether you're a seasoned pro, just starting out, or looking to learn something new, there's a place for you here.
because whether you're a seasoned pro or just starting out. Maybe you're already seasoned, is redundant
nujabes77
commented
8 months ago I didn't notice it. Good point !
On Mon, Feb 12, 2024 at 5:18 PM Jared Krajewski @.***> wrote:
New wording. 43 words shorter
Volunteering is all about making a difference and having fun while doing it. You don't need to worry about being the perfect fit - just bring your willingness to help out, and you're good to go!
We welcome people from all walks of life, whether you're a seasoned pro or just starting out. Maybe you're already seasoned, or perhaps you're looking to learn something new - either way, there's a place for you here.
So go ahead, dive into volunteering with enthusiasm, and let's make a positive impact together!
Contribute what you can, when you can, and know that your efforts are appreciated.
suggesting
We welcome people from all walks of life, whether you're a seasoned pro or just starting out. Maybe you're already seasoned, or perhaps you're looking to learn something new - either way, there's a place for you here.
to
We welcome people from all walks of life. Whether you're a seasoned pro, just starting out, or looking to learn something new, there's a place for you here.
because whether you're a seasoned pro or just starting out. Maybe you're already seasoned, is redundant
— Reply to this email directly, view it on GitHub https://github.com/codeforpdx/codepdx_website/pull/122#issuecomment-1940044232, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5R3GEYYCBDEQ54UDJ473TYTK5M5AVCNFSM6AAAAABDEDWICKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBQGA2DIMRTGI . You are receiving this because your review was requested.Message ID: @.***>
andycwilliams
commented
8 months ago Okay, here's what it looks like now.
The Volunteer button at the bottom looked a bit off to me so I adjusted the margins depending on screen size. Imo it looks a little more consistent when changing viewports. Can always revert it, though.
nujabes77
commented
8 months ago Should we try to place all in 2 text blocks? It doesn’t look to great to me or what do you think?
On Mon, Feb 12, 2024 at 18:53 Andy Williams @.***> wrote:
Okay, here's what it looks like now. Capture.PNG (view on web) https://github.com/codeforpdx/codepdx_website/assets/83156697/1354e759-7eac-4eec-a5d3-bcefcdc82241 Capture2.PNG (view on web) https://github.com/codeforpdx/codepdx_website/assets/83156697/c4534d80-c9cf-4120-8283-9cb5f50f66c4
The Volunteer button at the bottom looked a bit off to me so I adjusted the margins depending on screen size. Imo it looks a little more consistent when changing viewports. Can always revert it, though.
— Reply to this email directly, view it on GitHub https://github.com/codeforpdx/codepdx_website/pull/122#issuecomment-1940339864, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5R3GBU57V3PG5ZOWTVFO3YTLIT5AVCNFSM6AAAAABDEDWICKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBQGMZTSOBWGQ . You are receiving this because your review was requested.Message ID: @.***>
Jared-Krajewski
commented
8 months ago Should we try to place all in 2 text blocks? It doesn’t look to great to me or what do you think? … On Mon, Feb 12, 2024 at 18:53 Andy Williams @.> wrote: Okay, here's what it looks like now. Capture.PNG (view on web) https://github.com/codeforpdx/codepdx_website/assets/83156697/1354e759-7eac-4eec-a5d3-bcefcdc82241 Capture2.PNG (view on web) https://github.com/codeforpdx/codepdx_website/assets/83156697/c4534d80-c9cf-4120-8283-9cb5f50f66c4 The Volunteer button at the bottom looked a bit off to me so I adjusted the margins depending on screen size. Imo it looks a little more consistent when changing viewports. Can always revert it, though. — Reply to this email directly, view it on GitHub <#122 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5R3GBU57V3PG5ZOWTVFO3YTLIT5AVCNFSM6AAAAABDEDWICKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBQGMZTSOBWGQ . You are receiving this because your review was requested.Message ID: @.>
2 makes sense to me.
andycwilliams
commented
8 months ago Added the component and reduced to two lines.
I also trimmed the text a little more. Let me know what you think.
nujabes77
commented
8 months ago Nice! Looks good
On Mon, Feb 12, 2024 at 19:29 Jared Krajewski @.***> wrote:
@.**** approved this pull request.
— Reply to this email directly, view it on GitHub https://github.com/codeforpdx/codepdx_website/pull/122#pullrequestreview-1876815426, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5R3GA6XJY6GIJTLWK5BZ3YTLMZLAVCNFSM6AAAAABDEDWICKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZWHAYTKNBSGY . You are receiving this because your review was requested.Message ID: @.***>
This PR:
Resolves #117
Replaces single sentence with fuller description.
Screenshots (if applicable):
Future Steps/PRs Needed to Finish This Work (optional):
Opening as a draft to get feedback. This is a much larger piece of text and I don't know if people think it takes up too much room now, at least on mobile. Or maybe it can be trimmed to some extent.