Limit UI pages and functionality based on role - Githubissues

codeforpdx / dwellingly-app

Application for property managers to communicate with social workers

48 stars 28 forks source link

Limit UI pages and functionality based on role #840

Closed Chris-Boe closed 2 years ago

Chris-Boe commented 2 years ago

What issue is this solving?

Please connect this Pull Request to the issue it is resolving by using the controls on the right side of this PR. Closes #793

Any helpful knowledge/context for the reviewer?

Is a yarn install necessary? n Any special requirements to test? n

Please make sure you've attempted to meet the following coding standards

[x] There aren't any unnecessary commits or files changed
[x] Code has been tested and does not produce errors
[x] There isn't any unnecessary commented-out code

If you're having trouble meeting this criteria, feel free to reach out on Slack for help!

Chris-Boe commented 2 years ago

@NickSchimek it seems Staff members cannot query for the list of Staff (GET api/staff_members returns a 403), but they can add and edit tenants, which queries for the list of staff members so they can pick a staff to assign to the tenant. Do we want to allow staff members to see the list of staff, or when a staff member adds/edits a tenant we are assuming they are always going to assign themselves to the tenant?