codeforpdx / opentransit-metrics

Prototype of public transit data visualization system
https://opentransit-pdx.herokuapp.com/
MIT License
7 stars 8 forks source link

Can we disable `S3 Deploy` workflow under Actions? #22

Closed sidetrackedmind closed 2 years ago

sidetrackedmind commented 2 years ago

issue

This workflow has been failing with every commit - https://github.com/codeforpdx/opentransit-metrics/blob/master/.github/workflows/deploy.yml. Can we disable it? Maybe create another issue for fixing it?

sidetrackedmind commented 2 years ago

only run this workflow - if secrets are configured secrets.AWS_ACCESS_KEY_ID do not run if not

liamphmurphy commented 2 years ago

Been doing a lot at work on migrating our Jenkins CI to GH Actions, so this caught my eye.

As for fixing the issue; I don't have admin access to the repo. Do those secrets exist in the Settings? It could be they disappeared when we forked...?

sidetrackedmind commented 2 years ago

I'm closing this issue because @liamphmurphy took care of it under PR #27.