search

codeforpdx / opentransit-metrics

Prototype of public transit data visualization system
https://opentransit-pdx.herokuapp.com/
MIT License
7 stars 8 forks source link

16 isochrone dropdowns #30

Closed erikjasso closed 2 years ago

erikjasso commented 2 years ago

Fixes #16. Makes Isochrone controls sibling of map, then uses CSS to position them on top of map below zoom controls.

sidetrackedmind commented 2 years ago

I pulled this branch and tested the dropdown. They work! Thanks @erikjasso!

I’m not a frontend person but this comment made sense to me:

When declared as Leaflet Control, the select menus in Isochrone controls don't expand. Declare the controls off the map and use CSS to place them on top of the map.

It seems like you changed this: <Control position="topleft" className="isochrone-controls">

To this: <div className="isochrone-controls">

I'm going to mark approve unless @youngj has any objections.

sidetrackedmind commented 2 years ago

I pulled this branch and tested the dropdown. They work! Thanks @erikjasso!

I’m not a frontend person but this comment made sense to me:

When declared as Leaflet Control, the select menus in Isochrone controls don't expand. Declare the controls off the map and use CSS to place them on top of the map.

It seems like you changed this: <Control position="topleft" className="isochrone-controls">

To this: <div className="isochrone-controls">

I'm going to mark approve unless @youngj has any objections.