codeforpdx / recordexpungPDX

A project to automate the expungement of qualifying criminal records in Oregon. This project is done in conjunction with Qiu-Qiu Law.
https://recordsponge.com
MIT License
52 stars 88 forks source link

Upgrade frontend npm dependencies #1634

Closed monocle closed 1 year ago

monocle commented 1 year ago

Per the Slack discussion, I'll start working on this.

Notes: Reach UI is not currrently maintained. This is blocking from updating React to 18x. The Reach UI team mentions alternative:

It would probably be better for long term maintenance just to use plain HTML/CSS.

KentShikama commented 1 year ago

@monocle Nice! Feel free to submit PRs one bullet at a time (or even in more granular chunks). My guess is swapping moment.js to dayjs would be a nice chunk.

monocle commented 1 year ago

In trying to upgrade the dependencies, I've run into a lot of little fixes. Here is my fork with the commits so far. The commits are pretty atomic. I could rebase if that would be better.

Questions:

KentShikama commented 1 year ago

I realized I missed this post. There should be a husky hook in this repository that you can run or make into a git commit hook. In general, smaller chunks are preferable at first. Feel free to reach out wherever. Tagging me will make it easier for me to follow @monocle.

monocle commented 1 year ago

@KentShikama Would it be okay to change our node image to 18-bullseye? I think we need to upgrade node for the other package upgrades. Also, I'm trying to use VSCode's dev container feature to access the node_modules (ex. prettier) within the Docker container and they have a node 18 bullseye version for their typescript-node image.

KentShikama commented 1 year ago

Sure! @monocle