codeforpdx / recordexpungPDX

A project to automate the expungement of qualifying criminal records in Oregon. This project is done in conjunction with Qiu-Qiu Law.
https://recordsponge.com
MIT License
52 stars 88 forks source link

Makefile, Docker Compose, eslint #1690

Open m-c-g opened 1 year ago

m-c-g commented 1 year ago

Hi, I'm Mark. I went to the last Code for PDX meeting.

This project seemed interesting so I forked it and started looking into it. I'm using a VMware instance of Ubuntu on a Mac for development.

I installed Docker and Docker Config but ran into errors in the Makefile when I ran make new.

Recent versions of Docker no longer treat docker-compose as an external program, it is now called as a command within Docker. As of the end of June 2023 the old syntax will no longer be supported.

From the documentation:

Important

The new Compose V2, which supports the compose command as part of the Docker CLI, is now available.

Compose V2 integrates compose functions into the Docker platform, continuing to support most of the previous docker-compose features and flags. You can run Compose V2 by replacing the hyphen (-) with a space, using docker compose, instead of docker-compose.

Changing all instances of docker-compose to docker compose in the Makefile fixed the problem I was having with make new.

On opening localhost:3000 the site came up but with an overlay with the following:

Compiled with problems:

ERROR

[eslint] EACCES: permission denied, mkdir '/src/frontend/node_modules/.cache'

On closing the overlay the site appeared to be working without any obvious problems.

I'm pretty new to all of this, I'm still very much in the learning stages with Docker and git/github. If I'm missing something or doing something wrong please let me know. --Mark

monocle commented 1 year ago

@m-c-g HI Mark. I'm relatively new to the project and have been wrestling with and learning about Docker over that time. When I started at the start of this year, I couldn't get the backend to work. We recently made some updates to the backend Dockerfile to get things working with M1 Macs. Hopefully that didn't cause problems.

If you're running Docker through a VM, that's completely out of my realm of experience. Maybe that can cause some issues?

I just rebuilt everything on my Mac using docker-compose commands and things seems to be working, but given what you said, sounds like it'd be good to update the Makefile.

There are a couple of other things I think we could work on with the Makefile and the compose.yml file. If you're interested, we could discuss on the Discord server.

image image
m-c-g commented 1 year ago

I'm actually running in a Linux VM to avoid problems. Docker is developed on Linux and the Mac/PC versions run on a VM behind the scenes anyhow. The docker version on a Mac is:

docker --version
Docker version 20.10.23, build 7155243

Linux:

Docker version 23.0.1, build a5ee5b1

These were both installed or updated a week ago so it looks like the M1 Mac version is lagging behind Linux.

I found this in reference to the error overlay: https://docs.npmjs.com/resolving-eacces-permissions-errors-when-installing-packages-globally

I have no clue yet about how to fix it in the context of this project though.

BTW, I do I need an invite or a link for the discord?

monocle commented 1 year ago

Here's the Discord invite https://discord.gg/UZEDAw4x

On Thu, Mar 30, 2023 at 1:26 PM m-c-g @.***> wrote:

I'm actually running in a Linux VM to avoid problems. Docker is developed on Linux and the Mac/PC versions run on a VM behind the scenes anyhow. The docker version on a Mac is:

docker --version Docker version 20.10.23, build 7155243

Linux:

Docker version 23.0.1, build a5ee5b1

These were both installed or updated a week ago so it looks like the M1 Mac version is lagging behind Linux.

I found this in reference to the error overlay:

https://docs.npmjs.com/resolving-eacces-permissions-errors-when-installing-packages-globally http://url

I have no clue yet about how to fix it in the context of this project though.

BTW, I do I need an invite or a link for the discord?

— Reply to this email directly, view it on GitHub https://github.com/codeforpdx/recordexpungPDX/issues/1690#issuecomment-1490907447, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4WPTAQZSCAAYZDAMGFQCCLW6XUBBANCNFSM6AAAAAAWMOI5QY . You are receiving this because you commented.Message ID: @.***>

m-c-g commented 1 year ago

The invite comes up as invalid...

monocle commented 1 year ago

Sorry about that. I just generated this https://discord.gg/tKrKQef2

On Thu, Mar 30, 2023 at 5:51 PM m-c-g @.***> wrote:

The invite comes up as invalid...

— Reply to this email directly, view it on GitHub https://github.com/codeforpdx/recordexpungPDX/issues/1690#issuecomment-1491143206, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4WPTAQY2EYUZZ5HWWD73NLW6YS7RANCNFSM6AAAAAAWMOI5QY . You are receiving this because you commented.Message ID: @.***>