search

codeforpdx / recordexpungPDX

A project to automate the expungement of qualifying criminal records in Oregon. This project is done in conjunction with Qiu-Qiu Law.
https://recordsponge.com
MIT License
52 stars 88 forks source link

Fixed COMPILED.pdf and updated PDF layout #1755

Closed emko-274 closed 3 months ago

emko-274 commented 3 months ago

to-do:

wittejm commented 3 months ago

Why did you have to modify the stylesheet?

emko-274 commented 3 months ago

Michael requested that we add a bigger margin to the PDF files, which I did by modifying the stylesheet.

wittejm commented 3 months ago

And you're customizing the stylesheet that we were downloading from somewhere?

On Fri, Aug 23, 2024, 5:59 PM emko-274 @.***> wrote:

Michael requested that we add a bigger margin to the PDF files, which I did by modifying the stylesheet.

— Reply to this email directly, view it on GitHub https://github.com/codeforpdx/recordexpungPDX/pull/1755#issuecomment-2307966901, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQB5HQ4WFVTO54PMUE5ZM3ZS7LH5AVCNFSM6AAAAABNAWKB56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHE3DMOJQGE . You are receiving this because your review was requested.Message ID: @.***>

wittejm commented 3 months ago

It was surprising to see such a large new file. I think that comments in the file mentioning where it came from, and noting the change you made from the original, would be helpful

On Fri, Aug 23, 2024, 6:01 PM Jordan Witte @.***> wrote:

And you're customizing the stylesheet that we were downloading from somewhere?

On Fri, Aug 23, 2024, 5:59 PM emko-274 @.***> wrote:

Michael requested that we add a bigger margin to the PDF files, which I did by modifying the stylesheet.

— Reply to this email directly, view it on GitHub https://github.com/codeforpdx/recordexpungPDX/pull/1755#issuecomment-2307966901, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQB5HQ4WFVTO54PMUE5ZM3ZS7LH5AVCNFSM6AAAAABNAWKB56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHE3DMOJQGE . You are receiving this because your review was requested.Message ID: @.***>

emko-274 commented 3 months ago

Yes, the new file just contains the text from the source that was originally being requested from (https://raw.githubusercontent.com/sindresorhus/github-markdown-css/gh-pages/github-markdown.css), with a one-line edit. Is it alright if I add the comment in the file where the new one is read from? I'm not sure how to write comments in the txt file so that they aren't read into the string that's supposed to contain only CSS, other than by skipping lines when reading, which I think might be awkward.

wittejm commented 3 months ago

Ah, that's why it's a txt file. Yea, explaining it and showing the URL in the comment when you call the file sounds good

On Fri, Aug 23, 2024, 6:23 PM emko-274 @.***> wrote:

Yes, the new file just contains the text from the source that was originally being requested from ( https://raw.githubusercontent.com/sindresorhus/github-markdown-css/gh-pages/github-markdown.css), with a one-line edit. Is it alright if I add the comment in the file where the new one is read from? I'm not sure how to write comments in the txt file so that they aren't read into the string that's supposed to contain only CSS, other than by skipping lines when reading, which I think might be awkward.

— Reply to this email directly, view it on GitHub https://github.com/codeforpdx/recordexpungPDX/pull/1755#issuecomment-2307976390, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQB5HVZQ6BXAWNZCZJNY6DZS7OC3AVCNFSM6AAAAABNAWKB56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHE3TMMZZGA . You are receiving this because your review was requested.Message ID: @.***>

emko-274 commented 3 months ago

Okay, I added the comment