codeforpdx / recordexpungPDX

A project to automate the expungement of qualifying criminal records in Oregon. This project is done in conjunction with Qiu-Qiu Law.
https://recordsponge.com
MIT License
49 stars 89 forks source link

Only set eligibility date if type eligibility is true #385

Closed NickSchimek closed 4 years ago

NickSchimek commented 4 years ago

Description

Currently eligibility date is set regardless when a charge is currently not time eligible, however it came to my attention that it could cause some confusion for users of the app. This could lead them to think that the charge will be eligible at that given date even though it says the charge is not type eligible.

Currently the TimeAnalyzer is using the method set_time_ineligible in BaseCharge.py. The method can definitely be refactored/improved so that the change can be easily implemented.

Please add appropriate test cases for expected behavior.

Please reach out to @poppa_nick on slack if any questions.

This task is done when:

wittejm commented 4 years ago

There are still some record results that have this bug, with the pre-existing example listed on the expungement the bug reports page

wittejm commented 4 years ago

Completed by a recent logic change in the backend (always compute time eligibility) and a change to the frontend (hide time eligibility for type-ineligible changes)