codeforpdx / website

Official Code for PDX website
https://www.codeforpdx.org
5 stars 7 forks source link

Update the social media icons and their spacing #29

Closed katrinasperry closed 2 years ago

katrinasperry commented 2 years ago

Blocked by #28

Create PR that merges to nav_bar-redesign branch

image

The navbar html can be found here: _includes/header.html

kgottfri commented 2 years ago

It looks like the screenshot of the icons in this issue is from the figma mobile nav bar redesign file. The desktop figma mockup includes the LinkedIn icon and a different github icon. I wanted to be sure which design we were attempting to work off of for now.

Edit: I noticed the issue was updated to remove the screenshot including the LinkedIn icon and replace with the current screenshot of just github, meetup, and twitter. Just want to verify that this is the intended design.

katrinasperry commented 2 years ago

@kgottfri good catch! That change of screenshot was because @NickSchimek decided we should build the mobile version first, and then add to it for desktop. So stick with the mobile mockup which is in the same Figma file.