codeforpdx / website

Official Code for PDX website
https://www.codeforpdx.org
5 stars 7 forks source link

Adjust "Our Partners" list to display as shown #40

Closed katrinasperry closed 2 years ago

katrinasperry commented 2 years ago

Create PR that merges to partner_list-redesign branch

image

NOTE: all partner logos are already on the current site - keep them as is!

The partners html file can be found in: sections/partners.html The _partners directory has all the md files <- probably don't need to modify that unless we're adding/removing partners.

curtisbarnard commented 2 years ago

Once I get the sponsor list updates approved and merged I'll update these cards. @katrinasperry a few design questions:

  1. Do you want the aspect ratio of the cards the same from mobile up to desktop?
  2. Do you want to maintain the current aspect ratio or use the updated aspect ratio from Figma:
    • Current Aspect ratio 2.14:
      • image
    • Updated aspect ratio 2.31:
      • image
  3. Confirm that I am removing the box shadow?

Thanks!

katrinasperry commented 2 years ago

I really don't have strong feelings about aspect ratios 😂 so if you have other ideas, please share! Here's my best guess:

  1. Yes, let's keep the same aspect ratio across desktop and mobile views.
  2. Let's maintain the current aspect ratio.
  3. Yes to removing the box shadow!

Thanks so much!

curtisbarnard commented 2 years ago

This is being taken care of on #70 , currently having some issues with getting the desktop layout to align correctly. See PR for more info.

container