codeforpdx / website

Official Code for PDX website

https://www.codeforpdx.org

5 stars 7 forks source link

Sponsor list redesign #65

Closed curtisbarnard closed 2 years ago

curtisbarnard commented 2 years ago

Description

Resolves #41
update sponsor cards to remove box-shadow and give them a white background. Update media queries to make cards larger on mobile

Type of changes

[ ] Bug fix
[x] New Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Screenshots (optional)

Mobile view:

Tablet View:

Desktop View:

curtisbarnard commented 2 years ago

@NickSchimek does this PR look OK? I'm still waiting to hear what Katerina says about the media query break point for the cards, but other wise I think It's good...hopefully...😅

NickSchimek commented 2 years ago

Yeah, I think it looks good. Thanks for the pics!. The header isn't updated which is good because that should probably be done at the same time as the others 👍

Actually I'm seeing something different than the images you shared.

Here is what I seeing: I'm not seeing the white card backgrounds that you have in your pic.

NickSchimek commented 2 years ago

There is a white background there though. Maybe I'm just not seeing it because the site background is the same color and there is not outline anymore? Is the new site background color supposed to be offwhite?

What is the question regarding the breakpoint?

curtisbarnard commented 2 years ago

@NickSchimek I believe that the section background is gray and @kgottfri is covering that in one of his PR's. Regarding break point's there are currently media queries that break at < 475px, < 660px and then above 660px. Kevin mentioned that other breakpoints he was seeing and using were 960px. In my option that break between 475 and 660 doesn't make sense and could just be covered by using < 660 px.

curtisbarnard commented 2 years ago

I think this can be merged. I updated the media query to break at 960px. The cards are currently white, and will stand out against the new background once that comes in from Kevin's branch. There will likely be a problem caused with some white spacing between sections down the line, but I don't think we should solve that on this PR. Here's the potential issue:

weird padding issue

I was able to solve it by giving each section 1px of padding on the bottom. If the issue does crop up I can totally take it and fix.