codeforpdx / website

Official Code for PDX website

https://www.codeforpdx.org

5 stars 7 forks source link

Footer redesign #67

Closed kgottfri closed 2 years ago

kgottfri commented 2 years ago

Description

Resolves #39
*Updated footer for desktop and mobile views. Donate button hidden on mobile view at 549px and smaller. Mobile breakpoint at 549px for column list style.

Type of changes

[ ] Bug fix
[X] New Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Screenshots (optional)

Insert screenshots of your work.

NickSchimek commented 2 years ago

I think these site css changes really need to be in their own PR as I can't approve this PR with those changes in here. If the container is causing issues then maybe we widen the container rather than removing it completely? I'm also seeing the update nav bar commit in this PR. We can pair on this to get the commits cleaned up if needed. Ideally there would only be commits related to the footer redesign in this PR.