Closed dntrply closed 3 years ago
Describe the general shape of this PR (new feature? refactor? bug fix? one-line change?)
Describe what changes are being made
Describe why these changes are being made
List the use cases and edge cases relevant to this PR
Describe how errors will be handled. How will we know if this code breaks in production
Describe any external libraries/dependencies added or removed in this PR
Describe any security risks are there regarding this change
Describe how you tested these changes
Link to relevant external documentation
[x] Example of a checked item (please remove when creating your Pull Request)
[ ] Linked to the Github Issues being addressed using the right sidebar :arrow_right:
[x] Have you discussed these changes with the project leader(s)?
[ ] Do all variable and function names communicate what they do?
[ ] Were all the changes commented and / or documented?
[ ] Is the PR the right size? (If the PR is too large to review, it might be good to break it up into multiple PRs.)
[ ] Does all work in progress, temporary, or debugger code have a TODO comment with links to Github issues?
[ ] If you changed the user interface, did you add before and after screenshots to below?
I realize I was working of an earlier version of the files. I'd rather close this pull request and submit a new request one I am working with the most recent code.
:scroll: Description
Describe the general shape of this PR (new feature? refactor? bug fix? one-line change?)
Describe what changes are being made
Describe why these changes are being made
List the use cases and edge cases relevant to this PR
Describe how errors will be handled. How will we know if this code breaks in production
Describe any external libraries/dependencies added or removed in this PR
Describe any security risks are there regarding this change
Describe how you tested these changes
Link to relevant external documentation
:clipboard: Mandatory Checklist
[x] Example of a checked item (please remove when creating your Pull Request)
[ ] Linked to the Github Issues being addressed using the right sidebar :arrow_right:
[x] Have you discussed these changes with the project leader(s)?
[ ] Do all variable and function names communicate what they do?
[ ] Were all the changes commented and / or documented?
[ ] Is the PR the right size? (If the PR is too large to review, it might be good to break it up into multiple PRs.)
[ ] Does all work in progress, temporary, or debugger code have a TODO comment with links to Github issues?
[ ] If you changed the user interface, did you add before and after screenshots to below?
:framed_picture: Screenshots and Screen Recordings
Before
After
:blue_book: Glossary