Open jeffersonken19 opened 3 years ago
This just needs to be plugged into authentication
@JMStudiosJoe Would like to assign this issue to @dnahol
Just started working on this.
This and other two linked issues say SMS and email notifications for agenda items were working back then (2021).
Tried testing that on my local instance today. Was able to create test meeting, but wasn't able to upload the example.csv agenda mentioned in the README under Architecture
. When I try, the frontend instance just hangs:
" Upload is its own express app and can be found in backend/agenda_upload_service/. The upload services will be brought up by docker-compose along with the other services. To upload, use the example file (backend/agenda_upload_service/example.csv), then do:
curl --form csvfile='@backend/agenda_upload_service/example.csv' -F csvfile=example.csv localhost:3002/upload "
I'll bring this up at the meeting today.
Hello, I did some more research on the double opt-in, and here are my findings:
Twilio supports automatic opt-out on any SMS if the user replies "STOP". Below is an example:
Twilio supports opt-in/opt-out on the phone number level. Therefore, we can't have them subscribe to a single meeting notification while unsubscribing to another one from within the SMS. They can of course do so from the app itself.
Regarding email opt-in, it would be best to follow the same semantics as SMS. The first time you subscribe with an email you are sent an opt-in email and once the email is confirmed you can subscribe to any number of subsequent meetings without further opt-in requirements. In every email, there will be an opt-out link which just like SMS is a permanent mute switch.
A more secure route is to remove guest notification and make everyone authenticate with email and password and we again do a one time opt-in email. This might be overkill for V1.
This is related to the https://github.com/codeforsanjose/gov-agenda-notifier/issues/97 which is what I'm working on right now. Regardless of the approach, this current task should be blocked till the linked one is complete.