search

codeforsapporo / covid19

北海道 新型コロナウイルス対策サイト
https://stopcovid19.hokkaido.dev/
MIT License
128 stars 28 forks source link

lintの追加第1段 #332

Closed daisuke-fukuda closed 4 years ago

daisuke-fukuda commented 4 years ago

📝 関連issue

⛏ 変更内容

今回は環境を整えるところまで。実際にfixコマンドで修正するのは第2段の予定。

netlify[bot] commented 4 years ago

Deploy preview for code-for-sapporo-covid19-deploy-preview ready!

Built with commit 4d2fd39b685d1fe5886877d539a2819bfd819900

https://deploy-preview-332--code-for-sapporo-covid19-deploy-preview.netlify.com

daisuke-fukuda commented 4 years ago

あれ、lint OKって出ちゃうななんでだ

daisuke-fukuda commented 4 years ago 
reviewdog: This is Pull-Request from forked repository.
GitHub token doesn't have write permission of Check API, so reviewdog will
report results via logging command [1].

[1]: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#logging-commands
reviewdog: Reporting results for "stylelint"
reviewdog: No results found for "stylelint". 145 results found outside diff.
daisuke-fukuda commented 4 years ago

うーん、やっぱりエラーにならないなぁ、、、

daisuke-fukuda commented 4 years ago

lintエラーの場合、↑のようになります。（デプロイプレビューも実行されるし、マージもできます）