Closed jwhitlock closed 10 years ago
BOACase
and TMAPCCase
are so similar - they really look like they want a common parent BPZCase
? Or maybe we just want a BPZCase
model with no sub-classes? And we can rely on load_boa_cases
and load_tmapc_cases
commands to do the heavy lifting?
I agree, they look similar enough for a shared Case model.
django.contrib.gis.utils.LayerMapping
makes it easy to import data but doesn't give you any hooks for transforming that data, which means it can't write to the same model. We'll have to go down to per-feature importing to do that. I figure it will take 4-8 hours, which I don't think I have before Sept 8. We need to do it anyway (see all the TODOs in the management code), but I thought the API was a higher priority.
My plan was to capture all this stuff as issues, and combine the two models at the API. Once we have the API fleshed out enough that the front end folks can be productive, we can revisit models and importing. But, if your opinion is that this is more important, I can switch priorities, especially if someone else can implement the API.
Anxious to start building templates. Who is going to push the button on theses pull requests?
On Aug 25, 2014, at 8:16 AM, John Whitlock notifications@github.com wrote:
I agree, they look similar enough for a shared Case model.
django.contrib.gis.utils.LayerMapping makes it easy to import data but doesn't give you any hooks for transforming that data, which means it can't write to the same model. We'll have to go down to per-feature importing to do that. I figure it will take 4-8 hours, which I don't think I have before Sept 8. We need to do it anyway (see all the TODOs in the management code), but I thought the API was a higher priority.
My plan was to capture all this stuff as issues, and combine the two models at the API. Once we have the API fleshed out enough that the front end folks can be productive, we can revisit models and importing. But, if your opinion is that this is more important, I can switch priorities, especially if someone else can implement the API.
— Reply to this email directly or view it on GitHub.
I'm going to try to merge the two models.
Merge is going well, but I'll need a couple more hours to finish it. I plan to push new code on Tuesday Aug 26.
Cool, thanks @jwhitlock. @jdungan - which API do you need "filled in" before you can start?
I need to get postgis installed. Django install instructions using wget not successful. Anyone up to testing install process at lunch?
On Aug 26, 2014, at 7:15 AM, luke crouch notifications@github.com wrote:
Cool, thanks @jwhitlock. @jdungan - which API do you need "filled in" before you can start?
— Reply to this email directly or view it on GitHub.
@jdungan I can meet downtown / midtown. It's been a while, but I used brew install postgis
(http://brew.sh).
Luke beat you to it. We are meeting at the panera at 91st and memorial at noon. You're welcome to join us.
On Aug 26, 2014, at 9:14 AM, John Whitlock notifications@github.com wrote:
@jdungan I can meet downtown / midtown. It's been a while, but I used brew install postgis (http://brew.sh).
— Reply to this email directly or view it on GitHub.
@groovecoder is the code OK to merge now?
Apart from those refactors, this is looking really sweet. I was able to load the boa-cases.json
, tmapc-cases.json
, and home-owners-associations.json
with the management commands.
r+ and you can fix as many of the refactors as you want now, or else just file a follow-up issue for the refactorings.
I'm starting to build up the API endpoints on top of these models already in https://github.com/groovecoder/BPZAround.me/compare/search-api-4?expand=1
Added issue #28 for refactor. I think it will take a while to do right, and will add no new functionality, so it can wait.
Fixes #3. Includes:
BOACase
,HomeOwnersAssociation
, andTMAPCCase
modelsload_hoa
,load_boa_cases
, andload_tmapc_cases
./manage.py load data bps-2014-08-24
)There are still a number of import issues, because the GeoDjango LayerMapping doesn't have a lot of flexibility:
\/
is directly imported, rather than being converted to\/
Id
andUmbrella
are not imported, because they don't appear to have interesting dataPUD Site Plan\r\n\r\nPUD Site Plan'
, requiring cleanupI'll add these as post-prototype issues