codefrau / SqueakJS

A Squeak Smalltalk VM in Javascript
https://squeak.js.org
MIT License
365 stars 75 forks source link

Fix popping correct number of arguments #120

Closed ErikOnBike closed 3 years ago

ErikOnBike commented 3 years ago

The wrong popping method is used.

Might be because the interpreter and interpreter.proxy have different naming: 'popN' vs 'pop'. Maybe this should be changed (using 'popN' in the proxy as well instead of 'pop'), but it would require quite a few changes in the plugins as well as changes to the VMMaker code probably.