codefrau / SqueakJS

A Squeak Smalltalk VM in Javascript
https://squeak.js.org
MIT License
364 stars 75 forks source link

SoundPlayer has still room for improvement #127

Open LinqLover opened 3 years ago

LinqLover commented 3 years ago

Not sure whether this is a real issue, maybe just an observation:

AbstractSound stereoBachFugue play

At least on Chrome/Windows with a Squeak6.0 Alpha 64-bit image, the sounds plays all but not fluently. Nevertheless, the overall performance improvements since I have used SqueakJS the last time are very notable! :-)

Something that I would consider worse than the performance is that I was not able to interrupt the image from playing the sound by using Cmd + Dot. The debugger just did not appear. IMO interrupts should always be possible but apparently, the VM was overcharged with primitive calls and had no time to let the interrupt handler run. Could this be changed or is this a limitation by design? :-)

codefrau commented 2 years ago

Tweaking the SoundPlugin for more continuous playback is a good idea – we should be able to achieve gapless playback by proper scheduling, but it's not one of my priorities ATM. Help welcome :)