search

codefrau / SqueakJS

A Squeak Smalltalk VM in Javascript
https://squeak.js.org
MIT License
364 stars 75 forks source link

Very frequent "primitive 176 not implemented" in debugger running Cuis image #130

Closed nmingotti closed 2 years ago

nmingotti commented 2 years ago

Just a reminder. Of course if its not implemented its not implemented ;)

codefrau commented 2 years ago

For the numbered primitives we know about, we only print a warning once.

Having a numbered primitive we don't know about is potentially fatal so we log an error,

So thanks for this grabbing your attention :) I didn't know primitiveMaxIdentityHash existed, it appears to be unused in Squeak.

Now that we know about it we can turn it into a warning, or even just implement it.

codefrau commented 2 years ago

Can you try this with a Cuis image? If it works we can make a new release.

nmingotti commented 2 years ago

Done, far better now ! there are only a reasonable amount of messages in the JS developer console. Thanks.