search

codefresh-io / cli

Codefresh CLI
https://codefresh-io.github.io/cli/
MIT License
76 stars 36 forks source link

Support NodeJS 14 #643

Open logicbomb421 opened 3 years ago

logicbomb421 commented 3 years ago

Currently NodeJS 8 is EOL, and 10 is in Maintenance LTS for 21 more days (4/30). NodeJS 14 is currently in active LTS.

https://nodejs.org/en/about/releases/

My company has recently upgraded to 14 and all my CLI tooling is now breaking with:

Your node version (v14.16.0) is not compatible with supported node version (<=10.x >=8.x) for this command, click the link to see it in codefresh UI : https://g.codefresh.io/build/6070d1eaa8c50a53a0783fe6

Is there any reason 14 won't work in this util?

ramonsnir commented 3 years ago

@oren-codefresh I see that you added this version check about a year ago. Maybe you know why, and can amend it?

oren-codefresh commented 3 years ago

Hi @logicbomb421 @ramonsnir The reason that we added this check is due to the fact that the current firebase library that we are using doesn't support node version below 8 and greater than 10. It's a limitation right now that we are having. One can run builds from the CLI without follows the logs (those can be retrieved from the UI) Oren.