fix(downloader): replace `zip` with `adm-zip`

codefresh-io / cli

Codefresh CLI

https://codefresh-io.github.io/cli/

MIT License

76 stars 36 forks source link

fix(downloader): replace `zip` with `adm-zip` #801

Open ghost opened 1 year ago

ghost commented 1 year ago

zip library returns false for file permissions on Windows (library source), which is incompatible with file mode expected by Node.js File System API (File system API: chmod). This leads to TypeError in runtime.

adm-zip, instead, handles such cases correctly.

Fixes #CR-18233