search

codefresh-io / k8s-canary-deployment

Performing a kubernetes deployment with canary
https://codefresh.io/kubernetes-tutorial/fully-automated-canary-deployments-kubernetes/
MIT License
18 stars 16 forks source link

added HPA handling and bugfixes with input deployment #7

Closed rms1000watt closed 5 years ago

kostis-codefresh commented 5 years ago

Maybe I am missing something but I don't see 1) The parts where we backup HPA and restore it afterwards 2) Some conditional code to handle cases where HPA is not present at all.

rms1000watt commented 5 years ago
  1. There isn't. This is for the usecase that someone has an INPUT_DEPLOYMENT with an HPA defined. That usecase can be added later(?)
  2. The code shouldn't fail if it's not present.