search

codefresh-io / steps

36 stars 90 forks source link

update pagerduty_alert step.yaml #470

Closed ghost closed 2 years ago

ghost commented 2 years ago

Removed the default value for the assignee as it is not needed if there is an escalation policy

ghost commented 2 years ago

@lrochette I have updated the steps.yaml. Updated the version and remove the default value for ASSIGNEE_USER_ID. let me know if there is anything else needed.

ghost commented 2 years ago

This change is because there is an IF statement for ASSIGNEE_USER_ID. Why is the need for this if statement if we are passing in default values and it is not required? Also, you cannot use an escalation policy with this default value present.

Also, you cannot use False in the codefresh.yaml to disable this or not have a value for ASSIGNEE_USER_ID.

Please provide a better workaround @lrochette if you have one.