The Max File Upload is currently hardcoded to 1000MB which can sometimes not be enough in certain circumstances.
Why
Sometimes the upload can be over 1000MB which makes the step fail. Making it an argument allows users to specify the upload limit so it can be increased. It also allows users to reduce the value to ensure they don't upload too much by mistake.
Notes
I noticed that the docker image tag used on this step is ~4 years old so updating to my new tag includes some other changes to the cf-docker-test-reporting image. I've added cf_api_retries and report_path arguments as they were added to the docker test reporting executable. I've also added the image_tag argument as an escape hatch just in case it's necessary to target a specific image tag in the future.
Testing
I've tested this locally against a pre-release build of the docker image and it works as expected.
What
The Max File Upload is currently hardcoded to 1000MB which can sometimes not be enough in certain circumstances.
Why
Sometimes the upload can be over 1000MB which makes the step fail. Making it an argument allows users to specify the upload limit so it can be increased. It also allows users to reduce the value to ensure they don't upload too much by mistake.
Notes
I noticed that the docker image tag used on this step is ~4 years old so updating to my new tag includes some other changes to the
cf-docker-test-reportingimage. I've addedcf_api_retriesandreport_patharguments as they were added to the docker test reporting executable. I've also added theimage_tagargument as an escape hatch just in case it's necessary to target a specific image tag in the future.Testing
I've tested this locally against a pre-release build of the docker image and it works as expected.