issue-33 - Githubissues

codegnv / business-web

Permit Locator to Help Start Businesses

http://bdev.c4gnv.com.s3-website-us-east-1.amazonaws.com/

MIT License

7 stars 5 forks source link

issue-33 #122

Closed firoze closed 7 years ago

firoze commented 7 years ago

Completes issue #33 .

Changes in this pull request:

added searching for permit names (both required and conditional)
if at least one permit (required or conditional) contains part of the query, the business type is added to the results
search is not case sensitive

issue-33

Bjorn248 commented 7 years ago

@firoze I don't think we really have solid UX for this flow yet, we'll need to talk to @hollymariegibbs before going down a path here. I kind of like where the type search is right now, but the permit search remains a mystery (at least to me). The search that you implemented here is kind of a type search, because those are your main results, instead of permits. I'll leave this open for now to be used as a forum of discussion, or we can use #33

Bjorn248 commented 7 years ago

Going to close this for now, @hollymariegibbs knows that we need UX for permit search.

hollymariegibbs commented 7 years ago

Y u close dis

On Mar 8, 2017, at 22:30, Bjorn Stange notifications@github.com wrote:

Closed #122.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Bjorn248 commented 7 years ago

Let's use #33 to discuss