search

codegooglecom / libproxy

Automatically exported from code.google.com/p/libproxy
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Won't compile w/ xulrunner 2.0 final #158

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
svn version will not compile against xulrunner-2.0

/home/dylix/libproxy-read-only/libproxy/modules/pacrunner_mozjs.cpp:102: error: 
invalid conversion from ‘JSBool (*)(JSContext*, JSObject*, jsid, jsval*)’ 
to ‘JSBool (*)(JSContext*, JSObject*, jsid, JSBool, jsval*)’
make[2]: *** [libproxy/CMakeFiles/libproxy.dir/modules/pacrunner_mozjs.cpp.o] 
Error 1

Original issue reported on code.google.com by dyli...@gmail.com on 22 Mar 2011 at 12:49

GoogleCodeExporter commented 9 years ago 
Reproduced, and reported downstream here:

http://bugs.gentoo.org/show_bug.cgi?id=359879#c4

This is now a blocker for us...

Original comment by ssuomi...@unk.fi on 22 Mar 2011 at 6:46

GoogleCodeExporter commented 9 years ago 
Thanks for your report.

Which version of xulrunner-2.0 are you running? I just checked in r790 which 
fixes the latest API break in 2.0b12.

For 2.0 final, an additional patch on 
libproxy/cmake/modules/pacrunner_mozjs.cmk is probably needed (replace the 
pkgsearch>=2.0b12 to >=2.0; moz still does not get that 2.0b12 is > 2.0... 
bummer)

Original comment by dominiqu...@gmail.com on 22 Mar 2011 at 9:19

GoogleCodeExporter commented 9 years ago 
(actually, seems they marked xulrunner 2.0 final as 2.0.0, which in fact IS > 
2.0b12... GREAT.. thus r790 should build fine for you)

Original comment by dominiqu...@gmail.com on 22 Mar 2011 at 9:23

GoogleCodeExporter commented 9 years ago 
confirmed, I grabbed the whole "libproxy/cmake/modules/pacrunner_mozjs.cmk" 
file, and then svn diff -r789:790 of libproxy/modules/pacrunner_mozjs.cpp

this works for me against final xulrunner-2.0

thanks a lot

Original comment by ssuomi...@unk.fi on 22 Mar 2011 at 9:45

GoogleCodeExporter commented 9 years ago 
Thank you for confirming. Accepting the bug as fixed.

Original comment by dominiqu...@gmail.com on 22 Mar 2011 at 9:50

GoogleCodeExporter commented 9 years ago 
This patch allows cmake to correcly detect xul >= 2.0
Tested with cmake 2.8.3 and 2.8.4.
It fails to find the mozilla-js.pc if not

Original comment by kwiz...@gmail.com on 12 Apr 2011 at 1:37

Attachments:

GoogleCodeExporter commented 9 years ago 
kwitzart: in all releases of xul 2 I have seen 'around', the version is 
specified as 2.0.0, which is > 2.0b12... Is this not the case in Fedora? This 
was the assumption also used when adding this requires (> 2.0 would fail if 
somebody has 2.0b11).

Please let me know.. if this is indeed an issue on Fedora for example (which 
would be weird), I can apply this patch...

Original comment by dominiqu...@gmail.com on 18 Apr 2011 at 7:53