codegouvfr / react-dsfr

🇫🇷 The French Government Design system React toolkit
https://react-dsfr.codegouv.studio
MIT License
406 stars 51 forks source link

Feature/add tooltip component #176

Closed celineung closed 1 year ago

celineung commented 1 year ago

Add tooltip component

See DSFR doc

JeromeBu commented 1 year ago

Hi @garronej , I think @celineung has taken your suggestions into account and is waiting for your review

garronej commented 1 year ago

Oh yes sorry!
I'll look at this today

garronej commented 1 year ago

Hi @celineung,

Thank you for your contribution. The idea of applying the id to child elements is more effective than my initial suggestion. I also appreciate the inclusion of type-level tests.
I've merged and then rebased the changes, as there are several points we need to address:

I've opened a new PR.

Thanks for your efforts on this. If you have the time and interest to make these adjustments, that would be great. However, I understand that open-source contributions can be time-consuming, so no pressure to follow up if you can't. Your willingness to contribute is already appreciated.