codegouvfr / react-dsfr

🇫🇷 The French Government Design system React toolkit
https://react-dsfr.codegouv.studio
MIT License
406 stars 51 forks source link

fix: remove duplicate icon when input type date #180

Closed lsagetlethias closed 1 year ago

lsagetlethias commented 1 year ago

When an Input is type="date", DSFR already change the native icon with the ri-calendar icon in Webkit based browser.

In Firefox, since there is no -moz- support from DSFR, the native is displayed, therefore adding another one is wrong:

image

This PR remove the add of the date icon from the <Input /> component

enguerranws commented 1 year ago

Seems fine to me since the DSFR doesn't say anything about input date's icon overriding.

garronej commented 1 year ago

LGTM thanks!