feat(Badge): element can be a span (ref #200)

codegouvfr / react-dsfr

🇫🇷 The French Government Design system React toolkit

https://react-dsfr.codegouv.studio

MIT License

406 stars 51 forks source link

feat(Badge): element can be a span (ref #200) #201

Closed sbourdon13 closed 11 months ago

sbourdon13 commented 11 months ago

Badge can be a span or a p (default p). Same logic as the Summary component.
Update Badge default story
Create Header story with beta badge

Note: it works locally on storybook, but I'm not sure how to test on vite or next app for example. I launched the command yarn start-vite but it didn't create a local dev server, so I don't know what I'm supposed to do.

garronej commented 11 months ago

Thanks a lot!

Note: it works locally on storybook, but I'm not sure how to test on vite or next app for example. I launched the command yarn start-vite but it didn't create a local dev server, so I don't know what I'm supposed to do.

Hum maybe, the url is not prited in the console but the server is actually running... Or you are on windows and i'm using an explicit / path separator somewhere. Anywhere, there's no big deal!

I'm releasing a new version including you change.

sbourdon13 commented 10 months ago

Thanks! Yes I was working on Windows